eCharcha.Com   Support eCharcha.Com. Click on sponsor ad to shop online!

Advertise Here

Go Back   eCharcha.Com > Science and Technology > Computing

Notices

Computing All things binary...

Reply
 
Thread Tools Display Modes
  #1  
Old October 30th, 2003, 10:15 AM
YedaAnna's Avatar
YedaAnna YedaAnna is offline
Livin La Vida Loca
 
Join Date: Aug 2002
Location: eCharcha!!!
Posts: 5,713
YedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond repute
Question What coding practices do you follow?

I have been working on this government project since May this year. We are delivering the product on Nov 5. The product was developed by 5 different people and 4 were desi. Boy oh boy it is some kind of code. Now that it's about to be delivered, boss has started testing it. Fukka never looked at it for 3 years.

Every module mind ya comes up with a $hitload of bugs. Those fukkers have coded it like real shit guys. I have yet to come across coders so fukking bad An 8th grader codes better than these $hitheads. And we complain about not getting jobs. fukkers shud rot in hell

Everything is public, everything is global, arrays are indexed with constants, not a single comment, no error checking watsoever. itz spaghetti guys!!!

you come across such code?

how do you guys code? follow some guidelines? bcoz from what I have seen it's too bad out there!!!
Reply With Quote
  #2  
Old October 30th, 2003, 10:34 AM
Zen's Avatar
Zen Zen is offline
Senior eCharchan
 
Join Date: Jan 2001
Posts: 3,782
Zen is a name known to allZen is a name known to allZen is a name known to allZen is a name known to allZen is a name known to allZen is a name known to all
Wink

ye toh kuchh bhee nahee hai va~ts! meine toh 250 fields ke temp-tables with temp indexes across the app. window to window pass hote dekhe hain - woh bhee not as input and output parameters but only as inputs and that too to modify 2 fields! at the close event of the window before closing the whole table is sent to the parent window with 2 modifications as another input parameter!

Ye thread bahut saare programmers ke ghaav tazaa kar degaa!
Reply With Quote
  #3  
Old October 30th, 2003, 10:44 AM
Diplomat's Avatar
Diplomat Diplomat is offline
Senior eCharchan
 
Join Date: May 2002
Posts: 5,293
Diplomat has a reputation beyond reputeDiplomat has a reputation beyond reputeDiplomat has a reputation beyond reputeDiplomat has a reputation beyond reputeDiplomat has a reputation beyond reputeDiplomat has a reputation beyond reputeDiplomat has a reputation beyond reputeDiplomat has a reputation beyond reputeDiplomat has a reputation beyond reputeDiplomat has a reputation beyond reputeDiplomat has a reputation beyond repute
that is called team work.

where 1 guys fixes the errors/covers up the mistakes of 5 different people.
__________________
With Freedom comes Responsibility.
With Responsibility comes Freedom - Indian govt officials

Reply With Quote
  #4  
Old October 30th, 2003, 10:49 AM
echarcha's Avatar
echarcha echarcha is offline
Sutradhar {admin}
 
Join Date: Jul 2000
Location: CA, USA
Posts: 44,943
echarcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond repute
Cool Currently we are working on a product

which uses Java AWT extensivley and then some backedn java code.

Since we use a custom class loader and proprietary class compression and our JDSK is JDK1.1.8 we cannot use the ResourceBundle for localisation of strings. Hence we have a separate file which stores all strings. Easier to localise the product for our European market with French, German, etc.

Its no rocket science but other constants which are globally accessible and affect many places in the code are stored here.

We have a strict rule for adding a short descriptive paragraph at the top of each file about what the file does, which other files call it and which files are called by the file. Also author, date, version, etc. and any changes for subsequent versions have to be mentioned here. While we dont force comments for very simple things like declaring local booleans and other variables, we do force comments in proper Javadoc style before each method and variable of significance. Javadocs are generated every night when we make a daily build for unit testing.

Code review is something we always wish for but time is a luxury and hence we try to get in as much code review as we can. But to help in this process we have come up with some standards like minimising the use of inner classes and using them only when absolultey necessary or its more feasible like in event handling. Method names have to be proper and intuitive. No names like checkTrue(). This is nonsense. What are you checking? So we have longer method names but they help in the long run. Since our code gets developed here and in India, we have to follow these rules else the development will be a nightmare. Initially we did have some code jockeys from our India center who thought they were studs and believed that source code comments are for the stupid. Then we had to tame them down early on.

Then every night or atleast thrice a week we run JTest and PureCoverage on our code. Many high severity problems found in these test results are a must fix before product goes to testing team.

Also it depends on the mindset of the developers. If you are going to be just a code jockey then thats what you will be. Unless you think like a "solutions/product developer" where good coding is a part of the entire process, you can never deliver a good product. Also you should not have mental hangups like "Oh Java is the only way" or "MFC rocks and Java sucks". Many programmers have this attitude and hence they never become "product developers" but remain mere coders!

And lastly, we in the team, always think about - what if we are the end users using our product? Would we want a shoddy product?

This might sound idealistic but I see it in practise everyday in our company.
__________________
eCharcha.com
-Loud and Proud Desi Opinions
Reply With Quote
  #5  
Old October 30th, 2003, 11:04 AM
YedaAnna's Avatar
YedaAnna YedaAnna is offline
Livin La Vida Loca
 
Join Date: Aug 2002
Location: eCharcha!!!
Posts: 5,713
YedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond reputeYedaAnna has a reputation beyond repute
Re: Currently we are working on a product

Quote:
Originally posted by echarcha
Many programmers have this attitude and hence they never become "product developers" but remain mere coders!

And lastly, we in the team, always think about - what if we are the end users using our product? Would we want a shoddy product?
These are some excellent points that you have raised Khurch Pai.

So now comes the question. Do you see your coding from a product perspective or a module perspective. Do you guys keep the end user or environment in mind while coding and decide what's best to use or you just follow the specs?
Reply With Quote
  #6  
Old October 30th, 2003, 11:16 AM
Ravi's Avatar
Ravi Ravi is offline
Senior eCharchan
 
Join Date: Dec 2000
Location: Liberal Oasis
Posts: 2,515
Ravi has a reputation beyond reputeRavi has a reputation beyond reputeRavi has a reputation beyond reputeRavi has a reputation beyond reputeRavi has a reputation beyond reputeRavi has a reputation beyond reputeRavi has a reputation beyond reputeRavi has a reputation beyond reputeRavi has a reputation beyond reputeRavi has a reputation beyond reputeRavi has a reputation beyond repute
Yeda,
Coding practices are different from Software Development Process. You might have been using, say for e.g Hungarian notation, or a crapload of comments, but that doesn't prevent bugs from creeping in. In the companies I have worked in the past, we have given utmost important to the process. We even got SEI-CMM 4. While its cumbersome to follow this process, and sometimes it seems outrightly foolish to do some stuff, it pays in the end.
From your post, it appears that there was little control over developers from your manager. A bad manager is the root of most failed projects.
__________________
() => new Beer();
Reply With Quote
  #7  
Old October 30th, 2003, 11:17 AM
Zen's Avatar
Zen Zen is offline
Senior eCharchan
 
Join Date: Jan 2001
Posts: 3,782
Zen is a name known to allZen is a name known to allZen is a name known to allZen is a name known to allZen is a name known to allZen is a name known to all
Yeda, I am confused about the kind of response you are expecting!

I have worked as contract programmer in various companies and believe me Lead programmers makes a lot of difference.

Even if you have ISO standards in place - shitty programmers keep messing up things if the lead guy is clone of AB Vajpai - Many places people do not document, comment or even indent the code, use goofy variables and do all the confusing stuff so that they could keep thier job!

Did you want to know about coding standards generally enforced where we work and how?
Reply With Quote
  #8  
Old October 30th, 2003, 11:56 AM
BlrBoy's Avatar
BlrBoy BlrBoy is offline
Senior eCharchan
 
Join Date: Dec 2001
Posts: 1,944
BlrBoy is on a distinguished road
in my company.. i have seen guys using XML documents to transfer 1 field data from page to page.. can anyone beat that.. and all this in the name of learning.. and that too in production system...


and i pity my friend who had to fix some bugs in that code..
__________________
BlrBoy has left the building
Reply With Quote
  #9  
Old October 30th, 2003, 12:01 PM
echarcha's Avatar
echarcha echarcha is offline
Sutradhar {admin}
 
Join Date: Jul 2000
Location: CA, USA
Posts: 44,943
echarcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond reputeecharcha has a reputation beyond repute
Re: Re: Currently we are working on a product

Quote:
Originally posted by YedaAnna
These are some excellent points that you have raised Khurch Pai.

So now comes the question. Do you see your coding from a product perspective or a module perspective. Do you guys keep the end user or environment in mind while coding and decide what's best to use or you just follow the specs?
Thanks.

Marketing, as usual, wants the moon. We first study what can be delivered in the product release timeline and what cannot be. We make this very clear with the marketing team.

With a fair idea of what can be done, we set out with writing specs. In our team each member has to write a spec. for his/her module. If its a bigger module then two or more members collaborate on the spec. We involve usability, field engineers, sales team and tech. support folks early on. We have learnt over the years that asking usability and especially the tech. support folks can help us avoid a lot of heartburn. Our tech. support is the first front which faces the customer if the product malfunctions or does not do things as expected by the customer. Feedback from the field engineers and the voice of teh customer represented by the sales team provide valuable feedback. You will be surprised but unless we get proper review and feedback from all four departments, we really dotn start coding. Our specs undergo atleast 4 revisions. And you might think we have lots of time to do this. Nope! We have very tight schedules and we have to manage it all within this time. Also we have rounds of internal team review of specs so that all team members can comment on each others specs. This helps a lot - trust me!

Then once the specs are finalised - and we never aim for having 100% in the specs - we start coding. Usually oru specs contain about 75% to 85% of the details. If we wait for complete specs then we will never finish coding. Once coding starts we involve test team right from the outset. Test team provides good feeback and we can change some minor details while coding.

We all think of how the customer will reach when they see our product? Why? If customer is not happy, then we get very poor points in the company wide customer satisfaction survey. And this affects our promotions, stock options grants, and achievement awards!! Boss, when it affects monetarily, you have to work harder at satisfying the customer. We treat the customer like king. Its an old philosophy that "Customer has to be happy at all times" but it is what really works.
__________________
eCharcha.com
-Loud and Proud Desi Opinions
Reply With Quote
Reply

Bookmarks


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Can Coding/Quoting Prevent Indexing of Content ? khaski_khopari How to 7 March 2nd, 2011 01:08 PM
Indian Doctor's company prospers by questionable medical/business practices Ravi Life Abroad 11 July 28th, 2007 06:33 PM
PHP Coding Thread. TerminatorJR Computing 18 July 20th, 2006 11:53 AM
Do you know this Coding ?? viruss Computing 3 April 5th, 2004 09:54 PM
Oracle DB design: best practices... Thorn Computing 19 September 29th, 2003 12:00 PM


All times are GMT -7. The time now is 07:53 PM.


Powered by vBulletin® Version 3.7.2
Copyright ©2000 - 2017, Jelsoft Enterprises Ltd.
Site Copyright © eCharcha.Com 2000-2012.